New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teaching History and Languages with a Strategy Computer Game: 0 A.D. in the Classroom #613
Comments
Hello @scottkleinman and @historical-theology, You can find the key files here:
You can review a preview of the lesson here: I noticed a couple things when setting this file up, which I've listed below:
|
Hello Corey @historical-theology, I've sent you an invitation to join us as Outside Collaborators here on GitHub. This will give you the Write access you'll need to edit your lesson directly. (There's no need to use the Git Pull Request system in our ph-submissions repository). What's happening now?Your lesson has been moved to the next phase of our workflow which is Phase 2: Initial Edit. In this Phase, your editor Scott @scottkleinman will read your lesson, and provide some initial feedback. Scott will post feedback and suggestions as a comment in this Issue, so that you can revise your draft in the following Phase 3: Revision 1. %%{init: { 'logLevel': 'debug', 'theme': 'dark', 'themeVariables': {
'cScale0': '#444444', 'cScaleLabel0': '#ffffff',
'cScale1': '#882b4f', 'cScaleLabel1': '#ffffff',
'cScale2': '#444444', 'cScaleLabel2': '#ffffff'
} } }%%
timeline
Section Phase 1 <br> Submission
Who worked on this? : Publishing Assistant (@charlottejmc)
All Phase 1 tasks completed? : Yes
Section Phase 2 <br> Initial Edit
Who's working on this? : Editor (@scottkleinman)
Expected completion date? : May 5
Section Phase 3 <br> Revision 1
Who's responsible? : Author (@historical-theology)
Expected timeframe? : ~30 days after feedback is received
|
Hello, Corey @historical-theology Here are some initial comments on your tutorial.
Could you please address these issues in a revision before I send the tutorial out to external reviewers? And, of course, let me know if you have any questions. |
What's happening now?Hello Corey @historical-theology. Your lesson has been moved to the next phase of our workflow which is Phase 3: Revision 1. This Phase is an opportunity for you to revise your draft in response to @scottkleinman's initial feedback. You can make direct commits to your file here: /en/drafts/originals/teach-history-and-languages-with-strategy-game.md. @charlottejmc or I can help if you encounter any practical problems! When you and Scott are both happy with the revised draft, we will move forward to Phase 4: Open Peer Review. %%{init: { 'logLevel': 'debug', 'theme': 'dark', 'themeVariables': {
'cScale0': '#444444', 'cScaleLabel0': '#ffffff',
'cScale1': '#882b4f', 'cScaleLabel1': '#ffffff',
'cScale2': '#444444', 'cScaleLabel2': '#ffffff'
} } }%%
timeline
Section Phase 2 <br> Initial Edit
Who worked on this? : Editor (@scottkleinman)
All Phase 1 tasks completed? : Yes
Section Phase 3 <br> Revision 1
Who's working on this? : Author (@historical-theology)
Expected completion date? : May 8
Section Phase 4 <br> Open Peer Review
Who's responsible? : Reviewers (TBC)
Expected timeframe? : ~60 days after request is accepted
|
Revision based on the feedback of @anisa-hawes and @scottkleinman in #613
@anisa-hawes , @charlottejmc , and @hawc2 , thank you for configuring all of this for us, and @scottkleinman , thank you for your thoughtful, extensive feedback. I have prepared a thorough revision (ec83e84) in which I have aimed to take seriously everything mentioned thus far in this issue thread. While preparing the revision, I also have made a number of smaller changes throughout the piece to improve its clarity.
The adjustments look satisfactory. I am concerned about legibility at the reduced resolutions, but I also think that readers following the body text will not struggle to know what is being depicted in the images.
I have expanded the alternative text for every image with greater specificity. Please let me know if the updated alternative texts suffice (and, if not, how they might be improved further). Also, feel free to make direct commits to improve their functional utility for potential readers who might be unable to view the images.
I have overhauled Tutorial Overview to include nearly all of these things. In the process, I have used your encouragement to write a "short narrative" as a way to create a kind of orienting hook or lead-in for the reader.
I have moved all of these things to the endnotes.
I have reworked this part of the Requirements section.
I have overhauled the section entitled "A Scholarship-aware Community Endeavor," partly by combining it with the previous "Team Building" section and condensing the result.
It is standard practice for what are often colloquially referred to as "computer players" or "bots" to be labeled formally as artificial intelligence (AI) units/players. Is there something specific that ought to be clarified within the tutorial about this? If not, and I have answered your question, I am comfortable leaving those references to AI as they are.
I have removed all instances in which GIMP is framed as a requirement, instead noting specifically that the reader may use the image editing software of his/her choice. At the same time, I have left in-place the detailed steps in GIMP for the benefit of persons without any background in digital image editing, since performing those digital image editing steps is necessary for successful topographic image importation in Atlas for 0 A.D.
The attention to detail that you have shown, @scottkleinman , is laudable, and I appreciate it. Thus far, I have appreciated how straightforward this GitHub-based approach is for the Programming Historian. While I hope that you will find this revision to be ready to be issued to external reviewers, I will be happy to fulfill any follow-up request(s) for revision that you might have. @historical-theology Corey Stephan, Ph.D. |
Thanks for getting back to me @historical-theology. I agree that we should leave the images as they are, to ensure legibility. Thank you very much for your work on the alt-text – I've made some minor edits, but overall it looks great! |
Thank you, Corey @historical-theology. We really appreciate your work on this first round of revisions. Scott @scottkleinman will aim to review your changes within the next fortnight by ~May 31st. After that, we'll confirm the next steps. |
Programming Historian in English has received a proposal for a lesson, 'Teaching History and Languages with a Strategy Computer Game: 0 A.D. in the Classroom' by @historical-theology.
I have circulated this proposal for feedback within the English team. We have considered this proposal for:
We are pleased to have invited @historical-theology to develop this Proposal into a Submission under the guidance of @scottkleinman as editor.
The Submission package should include:
@historical-theology has already shared their Submission package with our Publishing team by email, copying in @scottkleinman. Our Publishing team will now process the new lesson materials, and prepare a Preview of the initial draft. They will run any questions by the contributor and post a comment in this Issue to provide the locations of all key files, as well as a link to the Preview where contributors can read the lesson as the draft progresses.
Our dedicated Ombudspersons are Ian Milligan (English), Silvia Gutiérrez De la Torre (español), Hélène Huet (français), and Luis Ferla (português). Please feel free to contact them at any time if you have concerns that you would like addressed by an impartial observer. Contacting the ombudspersons will have no impact on the outcome of any peer review.
The text was updated successfully, but these errors were encountered: