-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jose_server.erl - syntax error before: 'catch', function handle_call/3 undefined #4213
Comments
Looks like those commits helped, HEAD (392d7ee) builds fine now. |
The problem explained in this issue is a follow up of the previous one, both related to
Ok, that is Erlang/OTP 23.2. For erlang above 23, Otherwise (erlang not above 23), This is fixed in f7dc4fa BTW, this problem was not detected by the CI or Runtime workflows because they explicitly called "make update", which gets the dependencies as stated in rebar.config. This is fixed in 025e2a5 |
Oh wait, I did a mistake :( That's the system installed one, and I actually built a newer one and forgot to use its
But on a fresh clone I can't run Fresh clone I do: autogen/configure/make If I update the local clone, then I do: git pull/autogen/make update/configure/make This was learned from experience, aka updating a tree without doing |
erts 14.1.1 was included in https://www.erlang.org/patches/otp-26.1.2 If you are using OTP 26, then the version of Jose that rebar3 downloads is not affected (or should not be affected) by commit f7dc4fa ...
Well, it can be used anytime, either on clean build or when rebuilding. Of course, it makes little sense to run in on a clean build. To test the build process, CI and Runtime test workflows should not use it (fixed in 025e2a5 ), that way they test the typical (and documented) build steps:
Right, |
Environment
Erlang (SMP,ASYNC_THREADS) (BEAM) emulator version 11.1.8
(from source)Trying to build HEAD (13ebe89)
Last good build that I had was dbf0fb8
git bisect says:
The text was updated successfully, but these errors were encountered: