New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SASL2: Stable resource is used if no user-agent id is set. #4195
Comments
I fixed this recently in processone/xmpp@1b1418a |
This fixes crash in case of client sending bind2 tag but no user-agent, as we tried to use missing user-agent to generate stable resource.
But in my scenario there is a user-tag but no ID. Still ejabberd gives me a stable resource.
|
This change is not yet available in ejabberd, it was added to library that ejabberd uses, but ejabberd uses version of that library from before that change was introduced. And this change should also be triggered case where there is missing/empty id in user-agent |
@mdosch, messaging.one now has the commit in question, just in case you'd like to test it. If things look fine, this issue could be closed I guess. |
Seems to still set a stable resource in absence of user-agent id:
|
Hm, i will see if i can reproduce that then, but from looking at what code does i though we should be skip code that does that without id. |
Looks like i had a typo that didn't properly detect empty id - fixed in processone/xmpp@12a2e3f |
Thanks, I can confirm that it works now as expected.
|
Environment
@weiss might fill the gaps if necessary.
Configuration (only if needed): grep -Ev '^$|^\s*#' ejabberd.yml
unknown
Errors from error.log/crash.log
unknown
Bug description
Ejabberd is providing a stable resource although no id attribute is set in the user-agent element.
The text was updated successfully, but these errors were encountered: