VCARD Ldap Crash

[mixman68]

Hello

When 'im login I get this :

** {'module could not be loaded',
       [{lib,format_exception,
            [2,error,undef,
             [{lib,format_exception,
                  [2,error,undef,
                   [{lib,format_exception,
                        [2,error,
                         {case_clause,{error,not_implemented}},
                         [{mod_vcard,vcard_iq_set,1,
                              [{file,"src/mod_vcard.erl"},{line,395}]},
                          {ejabberd_hooks,safe_apply,4,
                              [{file,"src/ejabberd_hooks.erl"},{line,236}]},
                          {ejabberd_hooks,run_fold1,4,
                              [{file,"src/ejabberd_hooks.erl"},{line,217}]},
                          {mod_vcard,process_sm_iq,1,
                              [{file,"src/mod_vcard.erl"},{line,225}]},
                          {gen_iq_handler,process_iq,3,
                              [{file,"src/gen_iq_handler.erl"},{line,131}]},
                          {gen_iq_handler,process_iq,4,
                              [{file,"src/gen_iq_handler.erl"},{line,109}]},
                          {ejabberd_sm,route,1,
                              [{file,"src/ejabberd_sm.erl"},{line,146}]},
                          {ejabberd_router,do_route,1,
                              [{file,"src/ejabberd_router.erl"},{line,399}]}],
                         #Fun<misc.6.25947704>,#Fun<misc.7.25947704>],
                        []},
                    {ejabberd_hooks,safe_apply,4,
                        [{file,"src/ejabberd_hooks.erl"},{line,247}]},
                    {ejabberd_hooks,run_fold1,4,
                        [{file,"src/ejabberd_hooks.erl"},{line,217}]},
                    {mod_vcard,process_sm_iq,1,
                        [{file,"src/mod_vcard.erl"},{line,225}]},
                    {gen_iq_handler,process_iq,3,
                        [{file,"src/gen_iq_handler.erl"},{line,131}]},
                    {gen_iq_handler,process_iq,4,
                        [{file,"src/gen_iq_handler.erl"},{line,109}]},
                    {ejabberd_sm,route,1,
                        [{file,"src/ejabberd_sm.erl"},{line,146}]},
                    {ejabberd_router,do_route,1,
                        [{file,"src/ejabberd_router.erl"},{line,399}]}],
                   #Fun<misc.6.25947704>,#Fun<misc.7.25947704>],
                  []},
              {gen_iq_handler,process_iq,4,
                  [{file,"src/gen_iq_handler.erl"},{line,118}]},
              {ejabberd_sm,route,1,[{file,"src/ejabberd_sm.erl"},{line,146}]},
              {ejabberd_router,do_route,1,
                  [{file,"src/ejabberd_router.erl"},{line,399}]},
              {ejabberd_router,route,1,
                  [{file,"src/ejabberd_router.erl"},{line,92}]},
              {ejabberd_c2s,check_privacy_then_route,2,
                  [{file,"src/ejabberd_c2s.erl"},{line,865}]},
              {xmpp_stream_in,process_authenticated_packet,2,
                  [{file,"/ejabberd/deps/xmpp/src/xmpp_stream_in.erl"},
                   {line,725}]},
              {xmpp_stream_in,handle_info,2,
                  [{file,"/ejabberd/deps/xmpp/src/xmpp_stream_in.erl"},
                   {line,409}]}],
             #Fun<misc.6.25947704>,#Fun<misc.7.25947704>],
            []},
        {ejabberd_router,route,1,[{file,"src/ejabberd_router.erl"},{line,97}]},
        {ejabberd_c2s,check_privacy_then_route,2,
            [{file,"src/ejabberd_c2s.erl"},{line,865}]},
        {xmpp_stream_in,process_authenticated_packet,2,
            [{file,"/ejabberd/deps/xmpp/src/xmpp_stream_in.erl"},{line,725}]},
        {xmpp_stream_in,handle_info,2,
            [{file,"/ejabberd/deps/xmpp/src/xmpp_stream_in.erl"},{line,409}]},
        {p1_server,handle_msg,8,
            [{file,"/ejabberd/deps/p1_utils/src/p1_server.erl"},{line,696}]},
        {proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,249}]}]}

I use vcard_ldap with an active directory

  mod_vcard: {}
    # db_type: ldap
    # ldap_vcard_map:
    #   "NICKNAME": {"%u": []}
    #   "GIVEN": {"%s": ["givenName"]}
    #   "MIDDLE": {"%s": ["initials"]}
    #   "FAMILY": {"%s": ["sn"]}
    #   "FN": {"%s": ["displayName"]}
    #   "EMAIL": {"%s": ["mail"]}
    #   "ORGNAME": {"%s": ["company"]}
    #   "ORGUNIT": {"%s": ["department"]}
    #   "CTRY": {"%s": ["c"]}
    #   "LOCALITY": {"%s": ["l"]}
    #   "STREET": {"%s": ["streetAddress"]}
    #   "REGION": {"%s": ["st"]}
    #   "PCODE": {"%s": ["postalCode"]}
    #   "TITLE": {"%s": ["title"]}
    #   "URL": {"%s": ["wWWHomePage"]}
    #   "DESC": {"%s": ["description"]}
    #   "TEL": {"%s": ["telephoneNumber"]}
    # ldap_search_fields:
    #   "User": "%u"
    #   "Name": "givenName"
    #   "Family Name": "sn"
    #   "Email": "mail"
    #   "Company": "company"
    #   "Department": "department"
    #   "Role": "title"
    #   "Description": "description"
    #   "Phone": "telephoneNumber"
    # ldap_search_reported:
    #   "Full Name": "FN"
    #   "Nickname": "NICKNAME"
    #   "Email": "EMAIL"

Consider remove #, I have commented to prevent crashes

The server ldap is in readonly, it can be the issue ?

I use EjabberD image docker 21.12

and the config of vcard works with Ejabberd 18 (big upgrade)

[mixman68]

I changed the target for 21.07 and I have this

2022-02-24 08:09:56.201190+00:00 [error] Hook vcard_iq_set crashed when running mod_vcard:vcard_iq_set/1:
** exception error: no case clause matching {error,not_implemented}
   in function  mod_vcard:vcard_iq_set/1 (src/mod_vcard.erl, line 395)
   in call from ejabberd_hooks:safe_apply/4 (src/ejabberd_hooks.erl, line 236)
   in call from ejabberd_hooks:run_fold1/4 (src/ejabberd_hooks.erl, line 217)
   in call from mod_vcard:process_sm_iq/1 (src/mod_vcard.erl, line 225)
   in call from gen_iq_handler:process_iq/3 (src/gen_iq_handler.erl, line 131)
   in call from gen_iq_handler:process_iq/4 (src/gen_iq_handler.erl, line 109)
   in call from ejabberd_sm:route/1 (src/ejabberd_sm.erl, line 146)
   in call from ejabberd_router:do_route/1 (src/ejabberd_router.erl, line 399)

But no crash, so there is an issue with latest release

[badlop]

{case_clause,{error,not_implemented}},
  [{mod_vcard,vcard_iq_set,1,
    [{file,"src/mod_vcard.erl"},{line,395}]},

I use vcard_ldap with an active directory

The server ldap is in readonly, it can be the issue ?

Right, that's the case: vCard cannot be modified using XMPP.

This is mentioned in https://docs.ejabberd.im/admin/configuration/ldap/#ldap

Usually ejabberd treats LDAP as a read-only storage: it is possible to consult data, but not possible to create accounts or edit vCard that is stored in LDAP.

[mixman68]

Yes, in 21.07 it's the excepted behavior, the application raise not implemented and continues to login my user

in 21.12, the login process was interrupted and fatal error and crash was raised, it's not the excepted behavior

[badlop]

Aha!

The lib module was removed in OTP 21.0 (stdlib 3.5) erlang/otp#1786 as documented in https://www.erlang.org/doc/apps/stdlib/notes.html#stdlib-3.5

And the formatting options were moved to erl_error erlang/otp@a71c186

In ejabberd, the availability of erl_error is checked at compile time in rebar.config when using rebar2/rebar3, or in mix.exs when using Elixir's mix (and that's the case of the ejabberd docker image).

The bug was introduced in mix.exs in 8d8a317 That new line should have ++ at the end, so the next line gets added.

I've now fixed this in 7381b9d and then rewrote the workaround detection in f721374

Thanks for reporting!

[mixman68]

I check this answer, I don't know how I can test on my docker

[badlop]

The file misc.beam in the ejabberd 21.12 docker image was compiled using a buggy rebar.config. From what I see, misc.erl didn't change since May 2021, this means you could copy misc.beam from the old 21.07 image. Or compile it now and update it in the image