You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, from the source code, especially in doNf(num, left, right), there isn't check of type left === 'undefined', nor a default value for left, so when calling leftPart = leftPart.padStart(left, '0'), left cannot be undefined.
Also in the test suite of p5.prototype.nf, test cases are missing:
result = nf(1234), if leftis optional
result = nf([1234, 3.141516, 3.141516e-2], 2) for an array of numbers to format
The text was updated successfully, but these errors were encountered:
Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, please make sure to fill out the inputs in the issue forms. Thank you!
Hey, I am intrested in this isssue. As you said here.
However, from the source code, especially in doNf(num, left, right), there isn't check of type left === 'undefined', nor a default value for left, so when calling leftPart = leftPart.padStart(left, '0'), left cannot be undefined
did you meant that left can be undefined because that will make more sense if i am not wrong.
I can be wrong in this but i think p5._validateParameters('nf', arguments);
Here the arguments are being checked so that they are always correct or something of that sort.
But for test cases i think you are right we should have a test for array and test for only right argument.
Most appropriate sub-area of p5.js?
p5.js version
main branch
Web browser and version
No response
Operating system
No response
Steps to reproduce this
This is generally a report about the documentation and test cases.
From the reference, the prototypes for
nf
are:nf(num, [left], [right])
nf(nums, [left], [right])
However, from the source code, especially in
doNf(num, left, right)
, there isn't check oftype left === 'undefined'
, nor a default value forleft
, so when callingleftPart = leftPart.padStart(left, '0')
,left
cannot beundefined
.Also in the test suite of
p5.prototype.nf
, test cases are missing:result = nf(1234)
, ifleft
is optionalresult = nf([1234, 3.141516, 3.141516e-2], 2)
for an array of numbers to formatThe text was updated successfully, but these errors were encountered: