Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed.toml: add option to set default binary #1477

Open
tgross35 opened this issue Jan 31, 2023 · 3 comments · May be fixed by #2349
Open

Embed.toml: add option to set default binary #1477

tgross35 opened this issue Jan 31, 2023 · 3 comments · May be fixed by #2349
Assignees
@bugadani @juliankrieger
Labels
enhancement New feature or request

Comments

@tgross35
Copy link

Is your feature request related to a problem? Please describe.

Sometimes crates have >1 binary, but it's common to work with only one at a time.

Describe the solution you'd like

Under the [default.general] section of Embed.toml, add a default_bin or default_binary key that should get used by default. If --bin foo is specified by the CLI, ignore this value

Describe alternatives you've considered

You can currently pass --bin foo, but it's just an added step. I haven't found a way to default this via configuration
@tgross35 tgross35 added the enhancement New feature or request label Jan 31, 2023
@bugadani bugadani self-assigned this Apr 3, 2024
@juliankrieger
Copy link

@bugadani This also seems like not too hard of a problem to fix. You can assign this to me as well if you like.

@juliankrieger juliankrieger linked a pull request Apr 4, 2024 that will close this issue
Open
@bugadani bugadani linked a pull request Apr 5, 2024 that will close this issue
Add default_bin parameter to cargo-embed configuration file #2349
Open
@juliankrieger
Copy link

@bugadani I've been trying to think of a better way to map the output stream generated by cargo build's stderr to an Error, since I think it would be better for diagnostics if the config file is pointed out as the error source. Any ideas?

@bugadani
Copy link
Contributor

bugadani commented Apr 5, 2024

I'm not entirely sure I understand what you're trying to do. We pass --message-format=json(-and-some-extras) to cargo, does it even output anything to stderr, or do we receive cargo_metadata::Message objects? Take a look at build_artifact if you haven't already, it's where we process cargo's output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bugadani bugadani

@juliankrieger juliankrieger

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add default_bin parameter to cargo-embed configuration file juliankrieger/probe-rs
3 participants
@bugadani @tgross35 @juliankrieger