fix: add export for flag types #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmmm the CI error appears unrelated to this PR. I could push a fix but would rather keep the PR simple & focused on one thing. |
|
No worries. The CI error is expected—it fails because it's a fork. I'm using ESLint instead of Prettier. Stylistically, your changes look fine. Just to double check, how are you planning to use I think it's only used by cleye to enforce a base shape to the input flags (e.g. But if that's the use-case, I'm wondering if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
Unrelated question; do you use prettier? It surprised me when I went to contribute and my save by default made unrelated formatting changes w/ prettier defaults. I inferred what I think is close to your prettier config, but without a repo-specific prettier file, it makes it more difficult for folks to contribute. I'm sure you have a reason for doing things w/ your repos the way you do; I just want to understand :)
{ "singleQuote": true, "trailingComma": "all", "useTabs": true }Thanks!