Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parent flags in command #24

Closed
wants to merge 1 commit into from
Closed

feat: parent flags in command #24

wants to merge 1 commit into from

Conversation

ap0nia
Copy link

@ap0nia ap0nia commented Jun 23, 2023

Summary

An attempt to resolve #20

I don't think it works in the order specified:

git --no-pager log --pretty=oneline

since the command has to precede flags. But it should work fine with something like this, which is similar enough?

git log --no-pager --pretty=oneline

The command "log" comes before the parent flag "no-pager". I think I prefer it like this since it seems unusual to pass flags before a command even if they're technically associated with the parent, IMO.

Description

  • Simplified the parsing of the command array, and union-ed parent flags with the parsed command's flags.
  • cliBase now includes its parent flags (if any) as well as its own.
  • Was able to remove a ts-ignore that previously couldn't see parent flags.

@ap0nia ap0nia closed this by deleting the head repository Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get parent flags in command
1 participant