Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better queryset errors #38

Open
hhegre opened this issue Jan 10, 2022 · 3 comments
Open

Better queryset errors #38

hhegre opened this issue Jan 10, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@hhegre
Copy link
Contributor

hhegre commented Jan 10, 2022

Would be good if more queryset error messages reach the user. For instance, in :

.with_column(Column("ged_gte_25","country_month","ged_sb_best_sum_nokgx")

it would be very useful if this results in error messages telling us that "country_month" is not a table in the database and (if the table exists) that "ged_sb_best_sum_nokgx" is not a column in this table.

I understand some error message is produced in the logs, but it would be more convenient if they are visible from the notebook.

@Peder2911
Copy link
Contributor

Hey! This is a really important issue that I have been working towards here: #33

The underlying error handling code for providing better feedback has actually been written already, I just need to document the process and make the backend return useful error messages when appropriate. Thanks for raising this!

@Peder2911 Peder2911 added the enhancement New feature or request label Jan 17, 2022
@Peder2911 Peder2911 self-assigned this Jan 17, 2022
@Peder2911 Peder2911 changed the title Error messages Better queryset errors Jan 17, 2022
@Peder2911
Copy link
Contributor

Peder2911 commented Jan 28, 2022

Handling a lot of the underlying problems here: prio-data/views_queryset_manager#17

@Peder2911
Copy link
Contributor

Remedied by ^, although errors could still probably be made a lot better.

@Peder2911 Peder2911 reopened this Feb 1, 2022
@Peder2911 Peder2911 removed their assignment Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants