Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in temporal.decay #17

Open
jimdale opened this issue Oct 28, 2021 · 2 comments
Open

Bug in temporal.decay #17

jimdale opened this issue Oct 28, 2021 · 2 comments
Assignees

Comments

@jimdale
Copy link
Contributor

jimdale commented Oct 28, 2021

The temporal.decay function should presumably compute feature(t0)exp([t-t0]/tau), where t0 is the time when feature was last non-zero, but instead computes 2 ** ((-1 * feature(t) / tau_halflife).

@jimdale jimdale self-assigned this Oct 28, 2021
@hhegre
Copy link
Contributor

hhegre commented Nov 2, 2021

Are you sure this is a bug? It is convenient to have 2 as the base. Or what am I missing?

@jimdale
Copy link
Contributor Author

jimdale commented Nov 2, 2021

It's not so much a bug as a function with a slightly misleading name, in that it does not compute time decays on its own - you have to chain it with time_since.

I don't like using half-lives much (I prefer e-folding times), but that is just personal preference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants