Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menubar: Aria label not set to item label #5723

Closed
lisuzanne94 opened this issue May 10, 2024 · 1 comment
Closed

Menubar: Aria label not set to item label #5723

lisuzanne94 opened this issue May 10, 2024 · 1 comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@lisuzanne94
Copy link

Describe the bug

The aria-labels for the menubar items should be set to the item's label. Instead, they are all being set to aria-label="1".

<script setup>
import Menubar from 'primevue/menubar'
import { ref } from 'vue'

const items = ref([
    {
      label: 'label-one',
      items: [
        {
          label: 'sub-one',
        }
      ]
    },
    {
      label: 'label-two',
      items: [
        {
          label: 'sub-two-one',
        },
        {
          label: 'sub-two-two',
        },
        {
          label: 'sub-two-three',
          items: [
            {
              label: 'sub-sub-two-one',
            },
            {
              label: 'sub-sub-two-two',
            },
          ]
        }
      ]
    },
    {
      label: 'label-three',
      items: [
        {
          label: 'sub-three',
        }
      ]
    },
    ])
</script>

<template>
  <Menubar :model="items" />
</template>

<style scoped>
</style>

Screenshot 2024-05-10 at 1 10 44 PM

Reproducer

Wasn't able to reproduce in sandbox

PrimeVue version

^3.52.0

Vue version

3.x

Language

ES6

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

The menubar li elements should have aria-label="label-one", aria-label="label-two", etc. But they all have aria-label="1" instead.

@lisuzanne94 lisuzanne94 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 10, 2024
@lisuzanne94
Copy link
Author

Found the issue. We were using AudioEye which was interfering with the aria labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

1 participant