Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorPicker: Unused code remove #5671

Closed
Rekl0w opened this issue May 1, 2024 · 0 comments · Fixed by #5672
Closed

ColorPicker: Unused code remove #5671

Rekl0w opened this issue May 1, 2024 · 0 comments · Fixed by #5672
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@Rekl0w
Copy link
Contributor

Rekl0w commented May 1, 2024

Describe the bug

There are unused codes at ColorPicker component.

image

Reproducer

primevue/components/lib/colorpicker/ColorPicker.vue

Line 181 in fa42242

validateRGB(rgb) {

PrimeVue version

3.52.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@Rekl0w Rekl0w added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 1, 2024
Rekl0w added a commit to Rekl0w/primevue that referenced this issue May 1, 2024
@Rekl0w
Fix primefaces#5671: Unused codes removed
91fa272
@Rekl0w Rekl0w mentioned this issue May 1, 2024
Merged
tugcekucukoglu added a commit that referenced this issue May 16, 2024
@tugcekucukoglu
Merge pull request #5672 from Rekl0w/Fix#5671
3c4e621 
Fix #5671: Unused codes removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #5671: Unused codes removed Rekl0w/primevue
1 participant
@Rekl0w