Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: No longer allows modelValue: string #5655

Open
joemaylor opened this issue Apr 29, 2024 · 0 comments
Open

Calendar: No longer allows modelValue: string #5655

joemaylor opened this issue Apr 29, 2024 · 0 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@joemaylor
Copy link

Describe the bug

#3609 was reported and fixed in #4972, however this seems to have removed the option of passing a string representation of a date to the Calendar component.

Was this intentional? The implementation in Calendar.vue doesn't seem to have changed, in that it still accommodates the string type, e.g. https://github.com/primefaces/primevue/blob/master/components/lib/calendar/Calendar.vue#L2794

Throws TS Error:

<Calendar model-value="2024-07-01" />

Reproducer

https://stackblitz.com/edit/primevue-create-vue-typescript-issue-template-jggflg?file=src%2FApp.vue,package.json

PrimeVue version

3.52.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Nuxt

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to reproduction
  2. Run npm run type-check
  3. TS throws an error

Expected behavior

Should show no typescript errors.

@joemaylor joemaylor added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

1 participant