Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish to NPM along with PrimeNG? #62

Open
MetricMike opened this issue Oct 9, 2023 · 5 comments · May be fixed by #113
Open

Publish to NPM along with PrimeNG? #62

MetricMike opened this issue Oct 9, 2023 · 5 comments · May be fixed by #113

Comments

@MetricMike
Copy link

MetricMike commented Oct 9, 2023 •
edited

For custom theming (and minimal theme changes, like overriding the default blue in bootstrap4-light-blue), the docs (https://primeng.org/theming#customtheme) and GH Discussions (https://github.com/orgs/primefaces/discussions/148#discussioncomment-7150183) currently recommend cloning this repository in order to access the SCSS files.

Could this package instead get published to NPM alongside primeNG, so my package.json can download both of them in tandem? This would also let corporate users continue to leverage internal NPM registry mirrors.
@Phillip9587
Copy link

you can install it from github by adding the following dependency to your package.json:

{
    "dependencies": {
        "primeng-sass-theme": "github:primefaces/primeng-sass-theme#16.5.0"
    }
}

npm will install the package from github based on the given tag or commit sha

@MetricMike
Copy link
Author

Sorry, should have clarified that the goal here is to support build environments that otherwise could consume primeng, but can't consume the themes directly out of github. An example would be a fully-airgapped system, or a CI that limits connections to an internal NPM proxy that performs dependency scanning/auditing work, but not arbitrary GitHub repos.

@FrancoisJULIENNE
Copy link

Hello,

Why and what are the reasons for not putting this GITHUB repository in an NPM package?

@meriturva
Copy link

Any news here? it will be really useful to have a npm package!

vdlindk pushed a commit to vdlindk/primeng-sass-theme that referenced this issue Mar 26, 2024
build: publish the themes to npmjs
9806e41 
fix for issue primefaces#62
@vdlindk vdlindk linked a pull request Mar 26, 2024 that will close this issue
Open
@christophercr christophercr mentioned this issue Apr 2, 2024
Open
@christophercr
Copy link

Indeed, this would be quite useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resolves #62 publish themes to npmjs.org vdlindk/primeng-sass-theme
5 participants
@FrancoisJULIENNE @MetricMike @meriturva @christophercr @Phillip9587