New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish to npm? #71
Comments
Also has been mentioned on Discord and PrimeTek has put it on their list! |
I am so surprised that this is not the case already 🤔 |
I tried to add this repository to our dependencies via github dependency syntax and the install fails, probably because there is no package.json file. Maybe just add that? I don't think it has to be hosted on npm necessarily. |
Do you have instructions on how your included using GitHub syntax and then I can test and add a package.json. Thanks! |
Oh of course, I should have included a link to the documentation in the first message already: |
OK I added package.json but didn't test it yet if you want to test it: https://github.com/primefaces/primelocale/blob/main/package.json |
npm definitely treats this now as an npm package, but complains about trailing commas. i created a pull request that removes them |
You should now be able to do this in your package.json
|
The only issue we see in this solution now is that our company internal caches for depenency packages will not automatically work with github dependencies. I guess other people will have the same issue, so maybe uploading it to npm repo still makes sense. |
Agreed but according to the docs you can add a commit ID hash in your url and it will pull that version. Still not as good as in NPM but better than nothing |
React example how to use PrimeLocale: https://stackblitz.com/edit/react-3glwrd?file=src%2FApp.tsx,package.json,src%2Findex.tsx |
@melloware What docs are you referring to please? |
Sorry it's in the NPM docs for using just a git project like above. I had no idea you could do that. PrimeTek is aware and is working on getting this released for real on NPMJS. https://www.pluralsight.com/guides/install-npm-packages-from-gitgithub |
I guess this package is unofficial then. |
It is and I asked him to take it down. It's way out of date and should be released by PrimeTek. |
|
Would be simpler to use and update to newer versions.
The text was updated successfully, but these errors were encountered: