Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google LightHouse: font-display:block #361

Closed
melloware opened this issue Feb 21, 2021 · 5 comments · Fixed by #501
Closed

Google LightHouse: font-display:block #361

melloware opened this issue Feb 21, 2021 · 5 comments · Fixed by #501
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@melloware
Copy link
Member

melloware commented Feb 21, 2021

According to LightHouse: https://web.dev/font-display/?utm_source=lighthouse&utm_medium=devtools#how-to-avoid-showing-invisible-text

We should be using font-display: block; instead of the current font-display: auto;

block is what FontAwesome switched to: PikachuEXE/font-awesome-rails@f914464

FortAwesome/Font-Awesome#16077

@melloware
Copy link
Member Author

As a note I originally submitted this ticket but I think "auto" was the wrong choice.
#164

@melloware melloware changed the title Google LightHouse: font-diplay:swap Google LightHouse: font-diplay:block Feb 21, 2021
@onursenture onursenture changed the title Google LightHouse: font-diplay:block Google LightHouse: font-display:block Oct 21, 2021
@onursenture
Copy link
Member

I'm not sure about this issue & pull request. Please help. @mertsincan @cagataycivici :)

#501

@onursenture onursenture added the help wanted Extra attention is needed label Oct 21, 2021
@melloware
Copy link
Member Author

melloware commented Oct 21, 2021

I think its gone back and forth but Google is saying swap is the correct value.

From Google LightHouse suggestion: https://web.dev/font-display/?utm_source=lighthouse&utm_medium=devtools

image

@melloware melloware changed the title Google LightHouse: font-display:block Google LightHouse: font-display:swap Oct 21, 2021
@onursenture onursenture linked a pull request Oct 21, 2021 that will close this issue
@onursenture onursenture added this to the 4.2.0 milestone Oct 21, 2021
@Rotzbua
Copy link

Rotzbua commented Oct 21, 2021

I think its gone back and forth but Google is saying swap is the correct value.

Lighthouse thinks it is "normal" readable text.
It is not able to detect special icon fonts: GoogleChrome/lighthouse#10127

The swap makes sense for fonts which replace the international utf8 icons.

By default it is seems more common to use the block like the fa.

@melloware melloware changed the title Google LightHouse: font-display:swap Google LightHouse: font-display:block Oct 21, 2021
@melloware
Copy link
Member Author

OK then block it is.

cagataycivici added a commit that referenced this issue Oct 22, 2021
Fix #361: Ensure text remains visible during webfont load
@cagataycivici cagataycivici added enhancement New feature or request and removed help wanted Extra attention is needed labels Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants