Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileUpload (advanced): Multiple FileUpload - regressions when some files do not meet the limits #11900

Closed
christophs78 opened this issue May 9, 2024 · 3 comments · Fixed by #11965
Assignees
Labels
🐞 defect Bug...Something isn't working
Milestone

Comments

@christophs78
Copy link
Contributor

christophs78 commented May 9, 2024

Describe the bug

Uploading following files

image

13.0.x

image

14.0.0

image

Regressions

  • only one error is shown
  • after one error no further files are processed

Related to refactorings done for 14.0.0 as part of #11001, #11043, #11044

Reproducer

https://primefaces.org/showcase/ui/file/upload/multiple.xhtml
Select multiple files. Some within the size-limit. Some to big ones.

@christophs78 christophs78 added 🐞 defect Bug...Something isn't working ‼️ needs-triage Issue needs triaging labels May 9, 2024
@christophs78 christophs78 changed the title FileUpload (advanced): Multiple FileUpload - regressions when some files to not meet the limits FileUpload (advanced): Multiple FileUpload - regressions when some files do not meet the limits May 9, 2024
@melloware melloware removed the ‼️ needs-triage Issue needs triaging label May 9, 2024
@christophs78
Copy link
Contributor Author

Did some analysis....

Why do we get only one validation-error?
image

And - once there is any validation error nothing is uploaded any more:
image

So IMO a good amount of refactorings is required to restore the behaviour we had up to 13.0.x.
(Show a message for each file which does not meet´s the requirements. Allow to upload that part of files which meet the requirements.)

All of this is independent of (explicit) using CSV or using drag´n´drop - feature.

@tandraschko : I think we need at least your thoughts about this.

@tandraschko
Copy link
Member

tandraschko commented May 11, 2024

yeah, seems that the FileValidator would need to throw a array of msgs
this is a bigger refactoring

for me the behavior that we only upload when all files are valid is ok, we should just show all messages

@melloware melloware added this to the 15.0.0 milestone May 17, 2024
@christophs78 christophs78 self-assigned this May 18, 2024
@christophs78
Copy link
Contributor Author

christophs78 commented May 18, 2024

I´ll try to look at the one message per invalid file part. Maybe this is something we can fix for 14.0.x too. Let´s see.

christophs78 added a commit to christophs78/primefaces that referenced this issue May 18, 2024
…gressions when some files do not meet the limits
melloware pushed a commit that referenced this issue May 18, 2024
melloware added a commit to melloware/primefaces that referenced this issue May 18, 2024
…ad - regressions when some files do not meet the limits
melloware added a commit that referenced this issue May 18, 2024
…ssions when some files do not meet the limits (#11966)
@melloware melloware modified the milestones: 15.0.0, 14.0.1 May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 defect Bug...Something isn't working
Projects
None yet
3 participants