Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable: Select/unselect all with selectionPageOnly="false" does not work properly #11885

Closed
chaloma1 opened this issue May 7, 2024 · 7 comments · Fixed by #11911
Closed
Assignees
Labels
13.0.11 🐞 defect Bug...Something isn't working
Milestone

Comments

@chaloma1
Copy link

chaloma1 commented May 7, 2024

Describe the bug

Having a dataTable with selectionPageOnly="false" and paginator so i could select/unselect all items in a table. If i select all items in column header checkbox, it works fine, then i press button which processes whole form. After that i press the same checkbox to unselect all, but only single page is unselected.

Whole functionality works badly, for example if i select all and unselect all right after, it works.. but if i press the button between those steps or sometimes even just changing page, it does not unselect for all pages.

Reproducer

datatableUnselectAll.zip

Expected behavior

When selectionPageOnly="false" is set, i would expect it to work also for unselecting all items across all pages.

PrimeFaces edition

Elite

PrimeFaces version

13.0.9

Theme

No response

JSF implementation

Mojarra

JSF version

4.0.6

Java version

17

Browser(s)

No response

@chaloma1 chaloma1 added ‼️ needs-triage Issue needs triaging 🐞 defect Bug...Something isn't working labels May 7, 2024
@tandraschko
Copy link
Member

Can you please try 14.0?

@chaloma1
Copy link
Author

chaloma1 commented May 7, 2024

Tried with PrimeFaces 14.0.0, had to replace selection column parameter selectionMode="multiple" for selectionBox="true".

Bug still exists.

@melloware melloware removed the ‼️ needs-triage Issue needs triaging label May 7, 2024
@melloware
Copy link
Member

I think it might be related to this: #11556

@chaloma1
Copy link
Author

chaloma1 commented May 13, 2024

When i look at the 15.0.0 milestone label. I would appreciate, if this fix could be also pushed into 13.0.11 elite version. I will not be able to update 2 major versions in near future. Thank you.

@melloware
Copy link
Member

@chaloma1 it will have to go in 14.0.1 as once we are on a new major release the community is only supposed to update 1 version back.

@melloware melloware modified the milestones: 15.0.0, 14.0.1 May 13, 2024
@martin654
Copy link

@melloware Hi, this was marked as "Elite" so it would be fixed in 13.x.x version. Should we create ticket in PRO Jira for this?

@melloware
Copy link
Member

@martin654 Yes please open a PRO JIRA to have this backported to 13.x.x

melloware pushed a commit that referenced this issue May 15, 2024
…alse" does not work properly (#11911)

* Fix #11885 - DataTable: Select/unselect all with selectionPageOnly="false" does not work properly

* cosmetics

* it
melloware added a commit to melloware/primefaces that referenced this issue May 15, 2024
…tionPageOnly="false" does not work properly
melloware added a commit that referenced this issue May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13.0.11 🐞 defect Bug...Something isn't working
Projects
None yet
6 participants