Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration-tests: move to JakartaEE (10) #11877

Closed
christophs78 opened this issue May 5, 2024 · 6 comments
Closed

Integration-tests: move to JakartaEE (10) #11877

christophs78 opened this issue May 5, 2024 · 6 comments
Assignees
Labels
discussion Item needs to be discussed by core devs

Comments

@christophs78
Copy link
Contributor

christophs78 commented May 5, 2024

Description

Similar to #11433.
And kick out primefaces-integration-tests-jakarta which are a small subset of our whole test-suite.

Maybe provide a small set of IT´s which run against JSF 2.3 / JavaEE.

@christophs78 christophs78 added this to the 15.0.0 milestone May 5, 2024
@christophs78 christophs78 self-assigned this May 5, 2024
@christophs78 christophs78 changed the title Integration-test: move to JakartaEE (10) Integration-tests: move to JakartaEE (10) May 5, 2024
@tandraschko
Copy link
Member

hmmm
im a bit unsure about this
as long we have javax users, we are more safe with the current approach

@melloware
Copy link
Member

If anyone is interested I can use OpenRewrite and convert all the Javax tests into the Jakarta test so we run the same test suite on both? yes it is duplicating code and we have to update tests in 2 places but with the popularity of Faces 4.0 picking up maybe its worth it to have both full test suites?

@tandraschko
Copy link
Member

i would not duplicate for now and leave as it is, until we remove javax support
i dont think its worth to do something now

@melloware
Copy link
Member

ok

@christophs78 christophs78 removed this from the 15.0.0 milestone May 5, 2024
@christophs78 christophs78 added the discussion Item needs to be discussed by core devs label May 5, 2024
@melloware
Copy link
Member

melloware commented May 10, 2024

I think we have decided that this is a no for now?

@tandraschko
Copy link
Member

yeah, i would not change anything until 15.0 is released

i think we need to discuss first, when we drop javax support in general?
When we drop it soon, we can simple remove all javax stuff.
Otherwise i wouldnt change anything for now.

@melloware melloware closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Item needs to be discussed by core devs
Projects
None yet
Development

No branches or pull requests

3 participants