-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to opentelemetry-contrib #81
Comments
Hey @tsloughter, we are already discussing this internally. I'll come back to you as soon as we take a final decision! Thank you! |
Hi @tsloughter! We tried reasoning about giving this project to the community and maybe retaining our CI/CD pipeline, but that's not really possible. The easiest thing (for us) would be to "give you the code", we could still review PRs and solve eventual issues, but we wouldn't have ownership anymore. What do you think? |
@cpiemontese adding the code to |
But is there any automation in place or would we need to publish to hex manually? I don't know how other projects under |
It is currently manual, with both the original authors and otel maintainers able to publish. |
Sorry for the n-th question but I'm trying to understand better 😅 You said we'll retain "approval for any changes to the library with it in -contrib", does that mean we won't be able to merge PRs ourselves? |
Hm, sadly I don't think that is possible without giving permission to merge for all PRs to the repo. Would be more than happy to have more contrib maintainers (we need it) ;), but github doesn't provide a way to only give merge rights for PRs that touch specific parts of the repo. |
Hi again @tsloughter, I think we are ready to move telepoison to opentelemetry-erlang-contrib. Is there a checklist or something of what has to be done (aside from opening a PR with the code contained in this library)? |
Great! There is just this right now https://github.com/open-telemetry/opentelemetry-erlang-contrib/blob/main/CONTRIBUTING.md |
Would you be willing to submit this package to https://github.com/open-telemetry/opentelemetry-erlang-contrib/ ?
You can of course still maintain rights to the hex package and approval for any changes to the library with it in -contrib, but it makes it easier for users to find.
The text was updated successfully, but these errors were encountered: