Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not set created span as current span #15

Open
pdincau opened this issue Oct 5, 2021 · 0 comments
Open

do not set created span as current span #15

pdincau opened this issue Oct 5, 2021 · 0 comments

Comments

@pdincau
Copy link
Contributor

pdincau commented Oct 5, 2021

With @mbusi we noticed that we are currently setting as current span the span we create when the http request is issued, this forces us to store the original span and probably leads to incorrect behaviour when the http call fails for nxdomain.

A different approach could consist in storing the created span instead of the parent, not setting the span as current and then ending the stored span as:

Span.end_span(stored_span)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant