Disabled state of payment selection continue button

[iyzana]

Problem and impact

On the payment method selection screen the continue button can get into a wrong disabled-state when switching between payment methods that require additional input and ones that don't.

The process can only be continued by going back to ticket selection and then forward to the payment method selection again.

I noticed this on https://tickets.events.ccc.de/ so unfortunately I can't give exact URLs and this possibly depends on the concrete configuration and version.

Expected behaviour

When selecting a payment method that does not require additional input the continue button should be enabled

Steps to reproduce

On https://tickets.events.ccc.de/

1. Select a ticket to buy
2. Go to the payment method selection screen
3. Select Bank Transfer
4. Change selection to Credit Card, the continue button should now be disabled
5. Change selection back to Bank Transfer
6. The continue button stays disabled, even though it should be enabled again

Screenshots

No response

Link

https://tickets.events.ccc.de/

Browser (software, desktop or mobile?) and version

Firefox 120.0

Operating system, dependency versions

No response

Version

No response

[wiffbi]

I do not have a voucher code, so cannot proceed to checkout. Do you by chance know, which payment provider is used to offer credit card payment? Each payment option is basically a plug-in, which can load its own JavaScript and mess with the continue button …

[pc-coholic]

This is probably related to/caused by https://github.com/metarheinmain/pretix-reluctant-stripe

[raphaelm]

@iyzana Can you

• check your browser console (F12) for any error messages when this happens?
• check if any plugin in your browser blocks external resources for thsi site?

[iyzana]

I currently don't have a way to get to that step. But if each payment option loads its own JavaScript as @wiffbi said that may have just been a problem with my config and not a pretix bug.

Sorry I did not test thoroughly enough. But I now think the most likely cause was my own uBlock-Origin config blocking 3rd-party resources.

I don't know if that's a issue pretix should be resilient against, so the ticket may be closed if someone can confirm that that's the issue.

[wiffbi]

That is probably it. The stripe-JavaScript is directly loaded from stripe, ie. a 3rd-party domain. Regarding resilience: I guess it should, depending on the configuration if other payment options exist, at least once they are selected, the continue-button should be enabled again.