Misleading help text for free price input for add-on products

[ecanja]

Problem and impact

When creating an add-on product, it's possible to activate free price input (see #1298) and the functionality works as expected. However, the help text (below the checkbox "free price input" in the product configuration) still incorrectly states that this feature wouldn't work with add-on products. See the attached screenshot.

At first, this was very confusing to me and I had to test the booking process to see if the feature actually works. Even then, I was wondering if it really worked or if I was still missing something – until I found #1298. Only then I was pretty sure that the text is just outdated.

Expected behaviour

The help text should not say anymore that free price input is not possible for add-on products. The last sentence of the help text should probably just be removed.

The sentence also occurs in other languages (translations). There it should also be removed.

(I tried to change this myself, but I couldn't find the translations of the help text anywhere in the repo. And for the English text I'm not sure if it's enough to change the text in the source or if you need some kind of update mechanism.)

Steps to reproduce

1. Create an add-on product and go to the "Price" tab in the configuration of the product.
2. Read the help text for the checkbox "Free price input".

Screenshots

Link

No response

Browser (software, desktop or mobile?) and version

Firefox 117.0

Operating system, dependency versions

No response

Version

Current version of pretix Hosted on pretix.eu