Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickstart wizard: required fields marked as optional #3504

Open
luelista opened this issue Aug 3, 2023 · 1 comment
Open

Quickstart wizard: required fields marked as optional #3504

luelista opened this issue Aug 3, 2023 · 1 comment

Comments

@luelista
Copy link
Contributor

luelista commented Aug 3, 2023

Problem and impact

When choosing "Payment by bank transfer" in the quickstart wizard, the bank detail fields are marked as optional, but are actually required.

Expected behaviour

Fields are marked as required

Steps to reproduce

No response

Screenshots

Bildschirmfoto vom 2023-08-03 16-26-24

Link

No response

Browser (software, desktop or mobile?) and version

No response

Operating system, dependency versions

No response

Version

No response

@raphaelm
Copy link
Member

raphaelm commented Aug 7, 2023

Oh, yes. This is because they are "sometimes required" depending on what is selected above, which is a concept not known to the form renderer.

Since they are always either hidden or required, never visible and not required, a (very hacky, but working) fix could be replacing

                    {% bootstrap_field form.payment_banktransfer_bank_details_sepa_name layout="control" %}

with

                    {% bootstrap_field form.payment_banktransfer_bank_details_sepa_name layout="horizontal" %}

at least as long as the required labels are the only difference between those two renderers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants