Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gbagfx give some better error messages #673

Open
LOuroboros opened this issue Aug 16, 2018 · 4 comments
Open

Make gbagfx give some better error messages #673

LOuroboros opened this issue Aug 16, 2018 · 4 comments

Comments

@LOuroboros
Copy link
Contributor

LOuroboros commented Aug 16, 2018

I noticed that while gbagfx works with .png image files, if for whatever reason you have one of them named as (File).PNG, gbagfx won't work.
That's why I suggest to make it give better error messages that can make troubleshooting easier for the Users.

In this case, something like "Error: Your image file is not valid. Please make sure that its file extension is written in lowercase letters." would do, for example.

@aaaaaa123456789
Copy link

That's just one of many possible ways of writing the extension incorrectly. A much better error would point out that the extension wasn't recognized, and show the valid ones.

@LOuroboros
Copy link
Contributor Author

It was just an example, but I absolutely agree.

@RevoSucks
Copy link
Collaborator

do we really need this?

@LOuroboros
Copy link
Contributor Author

Unless you want people having to figure out on their own the reason why their sprite is not being converted with gbagfx (in case anyone randomly happens to come across this problem just like me), I'd say it would be a good thing to have, @ProjectRevoTPP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants