Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mid2agb output match #311

Open
yenatch opened this issue May 27, 2017 · 5 comments
Open

Make mid2agb output match #311

yenatch opened this issue May 27, 2017 · 5 comments

Comments

@yenatch
Copy link
Contributor

yenatch commented May 27, 2017

Right now all the songs in sound/songs/ have to be .s to match, since mid2agb can't convert to midi and back and still match. When this is fixed, the songs can be converted to midi.

@RevoSucks
Copy link
Collaborator

IIRC YamaArashi was having issues with the midi compression used with matching the .s files.

@Keitaro37
Copy link

Keitaro37 commented May 27, 2017

a while ago I started attempting to recreate the MIDI files byte by byte so that when compiled they would match the .s files exactly. This...proved to be stupidly tedious. still, the commands in MPlayDef.s are pretty detailed, which is helpful. Perhaps creating some type of script to generate a midi with the exact commands in the exact order as the .s file would do the trick, as that's exactly what I was doing by hand and it matched up perfectly.

@Keitaro37
Copy link

(actually, I seem to recall there was a file in the m4a engine documentation which further elaborated on various MIDI commands, if it would help, I can dig it up)

@yenatch
Copy link
Contributor Author

yenatch commented May 27, 2017

Yeah. Yama had a tool for converting .s to midi but it was lost, so we will have to recreate it.

@camthesaxman
Copy link
Contributor

I have a modified version of GBA Mus Riper, which was able to produce a matching bgm_pokecen.mid. https://github.com/camthesaxman/pokeruby_mus_riper I haven't tried any other songs yet. We still need to fix our mid2agb so that it can handle all of the MIDI commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants