Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support build on Java 11 #79

Open
dnskr opened this issue Apr 17, 2024 · 1 comment
Open

Support build on Java 11 #79

dnskr opened this issue Apr 17, 2024 · 1 comment

Comments

@dnskr
Copy link

dnskr commented Apr 17, 2024

Problem

Current implementation does not allow to build project using Java 11.

Issue 1

Module stats has missing dependency:

        <dependency>
            <groupId>javax.annotation</groupId>
            <artifactId>javax.annotation-api</artifactId>
        </dependency>

Solution: Add missing dependency.

Issue 2

Module jmx uses sun.management.Agent class in com.facebook.airlift.jmx.JmxAgent8:

import com.google.common.net.HostAndPort;
import sun.management.Agent;
import sun.management.jmxremote.ConnectorBootstrap;

Solution: cherry-pick airlift@cb70a83 or implement similar solution.

@dnskr dnskr changed the title Support build Java 11 Support build on Java 11 Apr 17, 2024
@rschlussel
Copy link

also let's add another github actions for java 11 so we don't break it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants