WIP: w.Write: replace to http.ResponseWriter.Write
#801
+42
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Avelino <avelinorun@gmail.com>
… header Signed-off-by: Avelino <avelinorun@gmail.com>
DiegoSantosWS
approved these changes
Apr 10, 2023
Signed-off-by: Avelino <avelinorun@gmail.com>
Signed-off-by: Avelino <avelinorun@gmail.com>
avelino
changed the title
http.ResponseWriter.Writehttp.ResponseWriter.Write
arxdsilva
requested changes
Apr 12, 2023
| w.Write([]byte(val)) | ||
| http.ResponseWriter.Header(w).Set("Cache-Server", "prestd") | ||
| http.ResponseWriter.WriteHeader(w, http.StatusOK) | ||
| http.ResponseWriter.Write(w, []byte(val)) |
There was a problem hiding this comment.
Since the 'http.ResponseWriter' is an interface not defined here, I believe that there is a chance that we get nil panics, isn't it?
|
abandoning this PR because it makes no sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: #800
ref