Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why can't I change surrounding pairs from curly quotes to other? #9

Closed
alerque opened this issue May 3, 2016 · 2 comments
Closed

Comments

@alerque
Copy link
Member

alerque commented May 3, 2016

I use vim-surround for manipulating matching pairs of quotes and other syntax. Adding vim-textobj-quote to the mix works great for getting motion commands for curly quoted strings. It also works out of the box to add a surround operator for curly quotes. Changing other surround symbols to curly quotes even works: using "this‸ string", typing cs"q will produce “this‸ string”. The issue I have is that it doesn't work the other direction: starting with “this‸ string” and typing csq" does nothing.

What's going on here? Is this a bug or do I have something setup wrong?

@reedes
Copy link
Collaborator

reedes commented May 4, 2016

It's been a long time since I was last in this code, but I'd speculate that you can't go backwards because vim-surround doesn't associate q with the curly quotes.

Sorry, but I won't have a chance to dig into this anytime soon, but if you can come up with a solution, I'd happily accept a pull request.

@alerque
Copy link
Member Author

alerque commented May 7, 2016

This appears to be a problem with vim-surround and I have come up with a fix that makes it work with the text object defined by this plugin. If it turns out that's not the right fix and there is something do do on this end I'll re-open this issue.

@alerque alerque closed this as completed May 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants