Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added visibility toggle for symlinks #1364

Closed
wants to merge 1 commit into from

Conversation

rzvxa
Copy link
Member

@rzvxa rzvxa commented Aug 21, 2023

… of symlinks.

Description of Changes

Closes #1352

Added a new setting g:NERDTreeShowSymlink, For filtering symlinks, This setting can be dynamically toggled, per tree, with the mapping.


New Version Info

Author's Instructions

  • Derive a new MAJOR.MINOR.PATCH version number. Increment the:
    • MAJOR version when you make incompatible API changes
    • MINOR version when you add functionality in a backwards-compatible manner
    • PATCH version when you make backwards-compatible bug fixes
  • Update CHANGELOG.md, following the established pattern.

Collaborator's Instructions

  • Review CHANGELOG.md, suggesting a different version number if necessary.
  • After merging, tag the commit using these (Mac-compatible) bash commands:
    git checkout master
    git pull
    sed -n "$(grep -n -m2 '####' CHANGELOG.md | cut -f1 -d: | sed 'N;s/\n/,/')p" CHANGELOG.md | sed '$d'
    git tag -a $(read -p "Tag Name: " tag;echo $tag) -m"$(git show --quiet --pretty=%s)";git push origin --tags

@rzvxa
Copy link
Member Author

rzvxa commented Aug 21, 2023

WindowsTerminal_EqD3k0Gapm.mp4
WindowsTerminal_tPIJlsQVND.mp4

Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced this addresses the feature request. I think the issue opener just wanted to hide the target of the links, not the fact that symlinks even existed. To be honest I'd hesitate to include this. I've seen tons of file manager interfaces that hide hidden files, but can't think of any that completely hide the existence of symlinks. At the very least I'd expect first to have the functionality to hide the targets (which look a little noisy) and only then to consider what the use case is for completely ignoring them.

@rzvxa
Copy link
Member Author

rzvxa commented Sep 3, 2023

I'm not convinced this addresses the feature request. I think the issue opener just wanted to hide the target of the links, not the fact that symlinks even existed. To be honest I'd hesitate to include this. I've seen tons of file manager interfaces that hide hidden files, but can't think of any that completely hide the existence of symlinks. At the very least I'd expect first to have the functionality to hide the targets (which look a little noisy) and only then to consider what the use case is for completely ignoring them.

I'm up for closing this PR, at first it seemed natural to add the ability to hide symlinks, But now that I'm thinking again about it, I think you are right maybe only hiding the linked path is enough

@alerque
Copy link
Member

alerque commented Sep 4, 2023

I'll close this for now. We can reconsider if anybody has a use case for it that they want to pitch. Personally I don't have one and can't imagine one, but that doesn't mean one doesn't exist. If we do include something like this it would be nice to know it actually met a need and didn't just add clutter to the docs.

In the mean time an option to hide symlink targets does seem to make sense to me.

@alerque alerque closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to hide file links in the directory tree?
2 participants