#convert_to_text misses closing a tag when no href is present but other attributes are

[ryanscottaudio]

The string "<a attr=\"attr\">foo</a><a href=\"test.com\">bar</a>", when run through convert_to_text, returns bar ( test.com ) (omitting the foo part entirely). I think this is because the regexes for a tags in #convert_to_text are missing everything between <a and the href in the SECOND a tag.

For comparison, "<a>foo</a><a href=\"test.com\">bar</a>" (removing attr=\"attr\") returns foobar ( test.com ). The regex skips the first a tag entirely.

[grosser]

sounds about right, pr welcome ... most likely just missing a ? somewhere in the regex 😞

[ryanscottaudio]

@grosser i have a fix but i don't have access rights, do i have to push to a fork or something?

[grosser]

make a fork

…

On Wed, May 12, 2021 at 10:36 AM Ryan Campbell ***@***.***> wrote: @grosser <https://github.com/grosser> i have a fix but i don't have access rights, do i have to push to a fork or something? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#404 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACYZ3G7OLEP4BDSWBG27TTNK4DLANCNFSM44XD5GBQ> .