New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Premailer output mangled when control chars are present in conditional comments #364

Open

iprlic opened this issue Aug 9, 2018 · 0 comments

iprlic commented Aug 9, 2018 •

edited

Run into this issue with \b char.

Example:

Premailer.new("<!--[if mso]>hello \bworld<![endif]-->", {with_html_string: true}).to_inline_css

Output:

<!DOCTYPE html PUBLIC \"-//W3C//DTD HTML 4.0 Transitional//EN\" \"http://www.w3.org/TR/REC-html40/loose.dtd\">\n" + "<html><body><p>world</p></body></html>\n

The comments have been stripped away, and all of the string before \b is missing.
This does not happen if the char is not in a comment.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment