Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to GH actions #621

Closed
tillkruss opened this issue Aug 11, 2020 · 13 comments
Closed

Move to GH actions #621

tillkruss opened this issue Aug 11, 2020 · 13 comments
Assignees
Milestone

Comments

@tillkruss
Copy link
Member

tillkruss commented Aug 11, 2020

Do we want to move to GitHub actions for the v2.0 branch? It would make it easy to test various Redis and PHP versions in a matrix.

@tillkruss tillkruss added this to the v2.0.0 milestone Aug 11, 2020
@nrk
Copy link
Contributor

nrk commented Aug 11, 2020

I can't really comment on GitHub actions because I've never used them. Any benefit from using them?

@tillkruss
Copy link
Member Author

I was thinking to test Redis 3.x with all supported PHP versions, then Redis 4.x and so on... at least that's what I've been doing with objectcache.pro

@AhmedRaafat14
Copy link
Contributor

I like this and I think the best benefit point we will get is having everything in one place which is GitHub.

@nrk
Copy link
Contributor

nrk commented Aug 11, 2020

I was thinking to test Redis 3.x with all supported PHP versions, then Redis 4.x and so on... at least that's what I've been doing with objectcache.pro

Sounds cool!

@tillkruss
Copy link
Member Author

@predishq/team: Anybody up for setting this up?

@mfn
Copy link

mfn commented Aug 12, 2020

predishq/team

image

Is it necessary to have this private? 🤔

@tillkruss
Copy link
Member Author

@mfn: It's a public team: https://github.com/orgs/predishq/teams

@srmklive
Copy link
Contributor

@tillkruss let me look into this.

@srmklive
Copy link
Contributor

Just to confirm, main branch is where changes would be merged?

@tillkruss
Copy link
Member Author

Yeah, main is the new master since BLM 👍🏻

@mfn
Copy link

mfn commented Aug 13, 2020

It's a public team

I stand correct, thank you! Just though the direct link could/should work.

Good day to make a fool of myself, apologies 🤷‍♀️

@mfn
Copy link

mfn commented Aug 13, 2020

Wait, no, actually not. I can't see anything there:
image

Ok, not a big deal anyway, just wanted to point it out => I'll see myself out 😏

@tillkruss
Copy link
Member Author

Solved in #634 and d4a170d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants