Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔍 add benchmarks #21

Open
jvdd opened this issue Jan 21, 2023 · 5 comments
Open

🔍 add benchmarks #21

jvdd opened this issue Jan 21, 2023 · 5 comments

Comments

@jvdd
Copy link
Member

jvdd commented Jan 21, 2023

Add benchmarks - that are reproducible - to this repo.

This would also allow contributors to check whether their changes impact (& possibly improve) performance :)

TODOs

=> try to make the Rust & Python benchmarks comparable - using same arraylength, n_out, dtype configurations

@jvdd
Copy link
Member Author

jvdd commented Feb 3, 2023

@jayceslesar
Copy link
Contributor

would be super cool to see some comparisons drawn from your paper -- unsure how the following graphs relate but below is a heatmap showing various differences in distance metrics for 250,000 data points and how they stack up against 10% retention (at most 25k points used in the n_out param)

newplot (5)

newplot (6)

@jayceslesar
Copy link
Contributor

Could also probably do like a png difference? Save the plot file and actually compare the resulting images somehow?

@jvdd
Copy link
Member Author

jvdd commented May 1, 2023

Hi @jayceslesar are you referring to the comparisons from this paper?

If so, I guess we can cross-reference our ts-datapoint-selection-vis repo!

As MinMaxLTTB is in its essence a novel algorithm (2-step algo using first MinMax & then LTTB), we ended up writing a desperate (short) paper about it (and did not include it in the ts-datapoint-selection-vis repo). The preprint of this paper will appear online tomorrow :) The benchmarks of MinMaxLTTB its visual representativeness are in our MinMaxLTTB repo


Could also probably do like a png difference? Save the plot file and actually compare the resulting images somehow?

That is exactly what we do for a matrix difference! We use DSSIM, PEM_20, and MSE to capture this! :)

@jvdd
Copy link
Member Author

jvdd commented May 2, 2023

@jayceslesar our paper on MinMaxLTTB https://arxiv.org/abs/2305.00332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants