Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this work with px.strip #229

Open
mkleinbort-ic opened this issue Jun 23, 2023 · 3 comments
Open

Does this work with px.strip #229

mkleinbort-ic opened this issue Jun 23, 2023 · 3 comments

Comments

@mkleinbort-ic
Copy link

I was excited to hear of plotly-resampler, as it seems to address my use-case very well.

However, I've been benchmarking this on some plotly figures that use px.strip - and I'm not seeing performance improvements.

Does plotly-resampler work with px.strip?

https://plotly.com/python/strip-charts/

@mkleinbort-ic
Copy link
Author

mkleinbort-ic commented Jun 23, 2023

Digging into it a bit, it seems px.strip uses the code for box-plots under the hood, specificaly the part that renders all the boxpoints

https://github.com/plotly/plotly.py/blob/696c30bf0131e8786a9dce050b772c1063550c6f/packages/python/plotly/plotly/express/_chart_types.py#L677

    return make_figure(
        args=locals(),
        constructor=go.Box,
        trace_patch=dict(
            boxpoints="all",
            pointpos=0,
            hoveron="points",
            fillcolor="rgba(255,255,255,0)",
            line={"color": "rgba(255,255,255,0)"},
            x0=" ",
            y0=" ",
        ),
        layout_patch=dict(boxmode=stripmode),
    )

image

I assumed this was using some for of px.scatter under the hood but now I'm not sure - but any thoughts about supporting this in plotly-resampler?

@mkleinbort-ic
Copy link
Author

I see this was clarified in #195

Any ambition to support other "scatter like" trace types?

@jonasvdd
Copy link
Member

jonasvdd commented Jul 26, 2023

Hi @mkleinbort-ic,

Currently, we are exploring whether we will support the aggregation of candlestick traces :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants