New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple non-modular if-else statement from the AggregatorParser #188

Open

1 task

jonasvdd opened this issue Apr 5, 2023 · 0 comments

Open

1 task

Decouple non-modular if-else statement from the AggregatorParser #188

jonasvdd opened this issue Apr 5, 2023 · 0 comments

Member

jonasvdd commented Apr 5, 2023 •

edited

#154 added a new hierarchy-based aggregator class structure, which requires different down sample implementations

Currently, this is resolved by an if-else statement in the PlotlyAggregatorParser its aggregate method, which is not that clean / modular.

Consider splitting the downsample and datapointselector into two different fields
that way you can avoid all of this switching and have well-defined types.
TODO:
add link to code location where this switching occurs.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment