Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-existing mapping is not detected #1997

Open
carme-hp opened this issue Apr 10, 2024 · 6 comments
Open

Non-existing mapping is not detected #1997

carme-hp opened this issue Apr 10, 2024 · 6 comments
Labels
bug preCICE does not behave the way we want and we should look into it (and fix it if possible) configuration Related to the preCICE configuration

Comments

@carme-hp
Copy link
Contributor

Describe your setup

Operating system (e.g. Linux distribution and version): Ubuntu 22.04
preCICE Version: 3.1.0

Describe the problem
After the creation of a compositional scheme (before finishing the first coupling timestep) consisting of a serial-explicit + parallel-implicit scheme, we face the following error in the participant which is present in both schemes:

image

The error was solved by adding a missing mapping to the crashing participant (see commit ).

Expected behaviour
preCICE should tell, that the mapping doesn't exist. Debugging xml files in compositional coupling schemes is challenging.

Additional context

FYI @davidscn

@carme-hp carme-hp added the bug preCICE does not behave the way we want and we should look into it (and fix it if possible) label Apr 10, 2024
@davidscn
Copy link
Member

Given the multitude of application scenarios, we cannot detect a 'missing mapping', as there are some scenarios, which don't require a mapping in the first place. What we could check, however, is that we try to read data (e.g. Displacement) on a mesh (MuscleMeshBottom), where we never receive this data (neither via a mapping nor via an exchange).

@fsimonis
Copy link
Member

fsimonis commented Apr 10, 2024

A naive check could verify that every mesh is either mapped or received by another participant. This would also play nicely with direct-mesh-access.

@uekerman could a participant write data to a mesh solely for the sake of providing a custom convergence measure or primary data for acceleration?

As @davidscn mentioned, this is also vaguely related to #1865, which would allow us to check this kind of issue on a data-level.

@fsimonis
Copy link
Member

@carme-hp isn't this easy to spot using the config-visualizer?

@carme-hp
Copy link
Contributor Author

I mean i didn't think that it would be a mapping thing, so i didn't see it. But yes, you can see it with the config-visualizer:
image

@uekerman
Copy link
Member

@uekerman could a participant write data to a mesh solely for the sake of providing a custom convergence measure or primary data for acceleration?

Yes, or for a watchpoint, for exporting, ...

@fsimonis
Copy link
Member

Meaning, that we cannot properly check this.

Providing for the sake of exporting sounds like it should be painless to turn the exporter off.

Receiving for the sole sake of using in a convergence measure or acceleration should also be easy to turn off.

Emitting warnings yes, but raising errors no. Correct?

@fsimonis fsimonis added the configuration Related to the preCICE configuration label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug preCICE does not behave the way we want and we should look into it (and fix it if possible) configuration Related to the preCICE configuration
Projects
Status: WP1.1 Configuration Tools (2024)
Development

No branches or pull requests

4 participants