Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Watchpoint files in non-watching participants #1989

Open
fsimonis opened this issue Apr 5, 2024 · 0 comments
Open

Empty Watchpoint files in non-watching participants #1989

fsimonis opened this issue Apr 5, 2024 · 0 comments
Labels
bug preCICE does not behave the way we want and we should look into it (and fix it if possible)
Milestone

Comments

@fsimonis
Copy link
Member

fsimonis commented Apr 5, 2024

Describe your setup

Operating system (e.g. Linux distribution and version): Yes
preCICE Version: develop (3.1.0 rc)

Describe the problem

When configuring a watchpoint in a participant, also other participants create the watchpoint log files.

This leaves empty watchpoint files around, which

  • can lead to confusion of the user
  • results in unnecessary files
  • makes automatic data aggregation and plotting more difficult as files are not unique.
  • can lead to problems when multiple participants run from the same directory as this is a filesystem race-condition. This is generally not the case though.

Step To Reproduce

  1. define a watchpoint on a mesh in one participant (the elastic-tube-1d tutorial is an easy-to-run example)
  2. run the case
  3. find a watchpoint log file in every participant directory.

Expected behaviour

Only write log files from the participant that is being run.

Additional context

  • Watchpoint/integral constructor opens the log file
  • ParticipantConfiguration::finishParticipantConfiguration creates watchpoints/integrals for every configured participant.

We need #982

@fsimonis fsimonis added the bug preCICE does not behave the way we want and we should look into it (and fix it if possible) label Apr 5, 2024
@fsimonis fsimonis added this to the Version 3.x.x milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug preCICE does not behave the way we want and we should look into it (and fix it if possible)
Projects
None yet
Development

No branches or pull requests

1 participant