Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log value distribution for consistent mappings #1986

Open
uekerman opened this issue Mar 28, 2024 · 1 comment
Open

Log value distribution for consistent mappings #1986

uekerman opened this issue Mar 28, 2024 · 1 comment
Labels
enhancement A new feature, a new functionality of preCICE (from user perspective)

Comments

@uekerman
Copy link
Member

Please describe the problem you are trying to solve.

It is sometimes difficult to quickly see whether a mapping does a good job or not. For a consistent mapping, one wants that the distribution of values (e.g. the average) stays the same (is this actually true?).

Describe the solution you propose.

We already give statistics on the computeMapping of NN and NP:

Mapping distance min:0 max:0.08 avg: 0.048 var: 0.000896 cnt: 25

We could log similar information for the actual values in each map call.

Pressure values before mapping (Fluid_Mesh) min:-10234 max:12365 avg: 10.23 var: ... cnt: 345
Pressure values after mapping (Solid_Mesh) min:-10000 max:12400 avg: 10.30 var: ... cnt: 112

I did not yet think much about details and wording.

For parallel participants, this would, of course, require global communication. So, there should be a way to switch this off, e.g. only have this for Debug builds.

What could be the equivalent for conservative mappings?

@uekerman uekerman added the enhancement A new feature, a new functionality of preCICE (from user perspective) label Mar 28, 2024
@mtree22
Copy link

mtree22 commented Mar 28, 2024

The equivalent for conservative mappings would be that the sum of the values on each mesh are equivalent:

Force values before mapping (Fluid_Mesh) min:-10234 max:12365 sum: 10.23 var: ... cnt: 345
Force values after mapping (Solid_Mesh) min:-10000 max:12400 sum: 10.30 var: ... cnt: 112

I would very much appreciate this, by the way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature, a new functionality of preCICE (from user perspective)
Projects
None yet
Development

No branches or pull requests

2 participants