Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix signals are not reactive on lazy imported components.(#301) #342

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fix signals are not reactive on lazy imported components.(#301) #342

wants to merge 1 commit into from

Conversation

ywang1724
Copy link

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2023

⚠️ No Changeset found

Latest commit: fae70c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Apr 10, 2023 •
edited

✅ Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit fae70c9
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/6433f4a4abe007000892df2a
😎 Deploy Preview https://deploy-preview-342--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rschristian rschristian linked an issue Apr 10, 2023 that may be closed by this pull request
Bug: signals aren't reactive on lazy imported components #301
Open
@XantreDev
Copy link
Contributor

XantreDev commented Sep 27, 2023 •
edited

I think its correct. And we should add forwardRef support

@XantreDev XantreDev mentioned this pull request Oct 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: signals aren't reactive on lazy imported components
2 participants
@ywang1724 @XantreDev