Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support static getDerivedStateFromError(error) #65

Closed
johnhaitas opened this issue Nov 2, 2018 · 1 comment
Closed

Support static getDerivedStateFromError(error) #65

johnhaitas opened this issue Nov 2, 2018 · 1 comment

Comments

@johnhaitas
Copy link
Contributor

In addition to supporting componentDidCatch (see #64) preact-render-to-string should support static getDerivedStateFromError(error)

Documentation here: https://reactjs.org/docs/react-component.html#static-getderivedstatefromerror
johnhaitas added a commit to johnhaitas/preact-render-to-string that referenced this issue Nov 2, 2018
@johnhaitas
Adds support for static getDerivedStateFromError(error). Should res…
64b1361 
…olve preactjs#65. Includes 3 tests.
@johnhaitas johnhaitas mentioned this issue Nov 2, 2018
Closed
@marvinhagemeister
Copy link
Member

Closing, support was added in #305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds support for static getDerivedStateFromError(error) johnhaitas/preact-render-to-string
2 participants
@johnhaitas @marvinhagemeister