Ambiguities with create command usage

[jamesgeorge007]

Do you want to request a feature or report a bug?
This proposal aims at changing the current behavior of the create command.

What is the current behaviour?
As specified in the docs, the create command expects the template-name and project-name (required arguments). However, the current implementation treats them as optional arguments.

preact-cli/packages/cli/lib/index.js

Line 44 in 4acc8c7

.command('create [template] [dest]')

If the current behaviour is a bug, please provide the steps to reproduce.

$ preact create default

preact-cli/packages/cli/lib/commands/create.js

Lines 209 to 214 in 4acc8c7

	async function command(repo, dest, argv) {
	validateArgs(argv, options, 'create');
	// Prompt if incomplete data
	if (!repo || !dest) {
	const templates = await fetchTemplates();
	const questions = requestParams(argv, templates);

The current implementation checks for a --template flag, which doesn't exist; hence the prompt to choose preactjs-template shows up even though it is specified.

preact-cli/packages/cli/lib/commands/create.js

Lines 81 to 87 in 4acc8c7

	function requestParams(argv, templates) {
	const cwd = resolve(argv.cwd);
	return [
	// Required data
	{
	type: argv.template ? null : 'select',

What is the expected behaviour?

preact create [project-name] [options]

• It would be better to add a --template flag.
• The --name flag is not required.

Please mention other relevant information.
N/A

[rschristian]

Sounds reasonable.

Feel free to submit a PR or something, otherwise I'll take a look when I get a block of time. I think I'll want to check over the other commands too just to make sure everything is matching up correctly.