Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running with multiple configurations #81

Open
sarayourfriend opened this issue May 3, 2022 · 2 comments
Open

Allow running with multiple configurations #81

sarayourfriend opened this issue May 3, 2022 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@sarayourfriend
Copy link

sarayourfriend commented May 3, 2022

Our application (https://github.com/WordPress/openverse-frontend) generates two distinct bundle groups during the build process, a "modern" and "universal" bundle (this is a concept we inherit by using Nuxt). We'd like to have separate compressed size checks for each of the two build types, however, when you try to run the compressed-size-check action twice in one PR, it overwrites the comment.

You can observe the issue in this PR: WordPress/openverse-frontend#1378

If you check the edit history of the bot's comment, you can see that it overwrote itself.

Would y'all accept a PR to add an optional "key"/"id"/"comment-key" (names are hard) input that could be used to specify the comment to update?

Essentially my idea would be to update this conditional to additionally check for the new input in the body: https://github.com/preactjs/compressed-size-action/blob/master/src/index.js#L202-L205

For example, instead of just compressed-size-check being in the body, it could be compressed-size-check::${key} or something along those lines.

Thanks!

@developit
Copy link
Member

developit commented Jun 6, 2022

A comment key configuration would be great! Your proposed implementation sounds right to me.

@developit developit added enhancement New feature or request help wanted Extra attention is needed labels Jun 6, 2022
@sarayourfriend
Copy link
Author

Hi @developit, I'm going to take a try implementing this today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants