Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate comments when using bot account #79

Open
flugg opened this issue Apr 11, 2022 · 0 comments · May be fixed by #80
Open

Duplicate comments when using bot account #79

flugg opened this issue Apr 11, 2022 · 0 comments · May be fixed by #80

Comments

@flugg
Copy link

flugg commented Apr 11, 2022

We have an issue where we want our organization bot account to be responsible for making the comment on the pull request. This can easily be done by changing the repo-token. However, there's a check in the code checking if the comment is posted by a bot user (https://github.com/preactjs/compressed-size-action/blob/master/src/index.js#L202). Regular bot accounts are not marked as bots, so this fails, and instead of updating the existing comment it instead posts a new.

The other check should be sufficient enough. Would you accept a PR that removes the bot-check?

Best regards

@flugg flugg linked a pull request Apr 11, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant