-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move to next track when playing an album track #182
Comments
Yeah, continuous playback has yet to be implemented. |
Continuous playback for audio should work in latest commit |
Should this be working in https://github.com/prayag17/JellyPlayer/releases/tag/v1.0.0-test02 already or is that limited to the changes for #119? |
It was already working |
Not sure I understand. It is not working here on macOS 13.6 and the just released test-build. Test build plays a single track of an album and does not play the next song. It also doesn't play another song when manually selecting any other track. |
Wdym manually selecting track? |
Clicking a track to start playing. It won't play after one track has played. There is the circular animation around the play button, but no audio will start playing. Just discovered this does not apply to all albums and now wondering what differentiates the problematic albums I see this issue with from those where manually selecting a track works. However even for the albums where manual selecting and playing a track works, but playing a track from an album still won't automatically move to the next track. |
Check if your album has track numbers |
Can you try changing the server to |
Don't use the change server instead remove the server by clicking on the user profile image in the header. Change server is yet to be implemented |
Well it is your server that's causing this issue, but idk what issue client has with your server |
Can you send me a screenshot of the console(left click and inspect) when the music ends |
Can you run the app as mentioned in Readme? |
Mentioned where? Can you elaborate how to do that? |
Oh that is maybe out of scope for me or will have to be postponed until the needed time is available as sadly I am not familiar with those mechanisms. |
Ok. I will try to reproduce it myself Edit: after doing some research, it turns out newer macos versions have some issues playing MP3 using web audio api. |
Thanks for digging into this. How does Jellyfin WebUI resolve this or are they not using the web audio api? |
Maybe they don't use MP3, I am not really sure. Since I don't have a Mac device I have no way of debugging this |
Feishin just released 0.4.1 and they seem to have fixed identical issue as per the release notes: Tested and can confirm that when using |
They seem to be using Electron which uses chromium which does not have this issue, the same reason why windows doesn't have this issue |
Do you know if an open issue for the web audio API problem exists already and if yes, could you share the link? |
I have switched from WebAudio Api to HtmlMedia element for audio playback which might fix this issue. |
macOS 13.6.1 Retested and first selected track still plays. Any other track which is selected won't play and player gets stuck. |
This has improved with Version 1.0.0 (20231208.093929). Track selection via track listing is possible and tracks are played after the initial track has been played. Using Back | Forth arrow icons to go to previous | next track works. What is not yet working is that quite frequently, however not always, track progress is not shown after the initial track has played and the progress indicator is stuck on the start of the track. Sometime also the issue where tracks selected from album track listing are not played is also persisting. |
Can you try the latest build (also ignore the update MSG, it is for testing) |
Is the latest build https://github.com/prayag17/JellyPlayer/releases/tag/v1.0.0-dev%40abca227 ? |
https://github.com/prayag17/JellyPlayer/releases/tag/v0.0.1-dev%40874646a this is the latest build. |
Same - while the second track does play (improvement over previous situation) the waveform indicator is not moving when the second track is playing. |
Is your feature request related to a problem? Please describe.
Currently when playing a track from an album playback stops once the track has been played.
Describe the solution you'd like
It would be great if JellyPlayer moved to the next track of the album and continued playing that until all remaining album tracks have been played.
JellyPlayer Alpha 2
macOS 13.6
The text was updated successfully, but these errors were encountered: