Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to next track when playing an album track #182

Open
foss- opened this issue Sep 29, 2023 · 33 comments
Open

move to next track when playing an album track #182

foss- opened this issue Sep 29, 2023 · 33 comments
Labels
enhancement New feature or request

Comments

@foss-
Copy link

foss- commented Sep 29, 2023

Is your feature request related to a problem? Please describe.
Currently when playing a track from an album playback stops once the track has been played.

Describe the solution you'd like
It would be great if JellyPlayer moved to the next track of the album and continued playing that until all remaining album tracks have been played.

JellyPlayer Alpha 2
macOS 13.6

@prayag17 prayag17 added the enhancement New feature or request label Sep 29, 2023
@prayag17
Copy link
Owner

Yeah, continuous playback has yet to be implemented.

@prayag17
Copy link
Owner

Continuous playback for audio should work in latest commit

@foss-
Copy link
Author

foss- commented Oct 7, 2023

Should this be working in https://github.com/prayag17/JellyPlayer/releases/tag/v1.0.0-test02 already or is that limited to the changes for #119?

@prayag17
Copy link
Owner

prayag17 commented Oct 7, 2023

It was already working

@foss-
Copy link
Author

foss- commented Oct 7, 2023

Not sure I understand. It is not working here on macOS 13.6 and the just released test-build. Test build plays a single track of an album and does not play the next song. It also doesn't play another song when manually selecting any other track.

@prayag17
Copy link
Owner

prayag17 commented Oct 7, 2023

Wdym manually selecting track?

@foss-
Copy link
Author

foss- commented Oct 7, 2023

Clicking a track to start playing. It won't play after one track has played. There is the circular animation around the play button, but no audio will start playing.

Just discovered this does not apply to all albums and now wondering what differentiates the problematic albums I see this issue with from those where manually selecting a track works. However even for the albums where manual selecting and playing a track works, but playing a track from an album still won't automatically move to the next track.

@prayag17
Copy link
Owner

prayag17 commented Oct 7, 2023

Check if your album has track numbers

@foss-
Copy link
Author

foss- commented Oct 7, 2023

It does:

@foss- foss- changed the title move to next track when playing a track from an album move to next track when playing an album track Oct 7, 2023
@prayag17
Copy link
Owner

prayag17 commented Oct 7, 2023

Can you try changing the server to https://demo.jellyfin.org/stable, and check if the album tracks there play in a series?

@prayag17 prayag17 reopened this Oct 7, 2023
@foss-
Copy link
Author

foss- commented Oct 7, 2023

Change server took me to a blank view with no fields to enter a server.

@prayag17
Copy link
Owner

prayag17 commented Oct 7, 2023

Don't use the change server instead remove the server by clicking on the user profile image in the header. Change server is yet to be implemented

@foss-
Copy link
Author

foss- commented Oct 7, 2023

Played the binaerpilot promo album and indeed it continued playing track number 4 after track number 1. So something is wrong with my server setup? It is Jellyfin 10.8.11.

@prayag17
Copy link
Owner

prayag17 commented Oct 7, 2023

Well it is your server that's causing this issue, but idk what issue client has with your server

@prayag17
Copy link
Owner

prayag17 commented Oct 7, 2023

Can you send me a screenshot of the console(left click and inspect) when the music ends

@foss-
Copy link
Author

foss- commented Oct 7, 2023

Sidenote: Playing tracks of an album works as expected in Jellyfin Media Player.

Here is the requested screenshot. Note: the initial 7 errors Failed to load resource showing initially seem unrelated. Checked the URLs and each is a video lacking a primary image.

Once the first track comes to the end, the following error shows:

[Error] Unhandled Promise Rejection: EncodingError: Decoding failed
	l (index-0a18ac56.js:422:6016)

@prayag17
Copy link
Owner

prayag17 commented Oct 7, 2023

Can you run the app as mentioned in Readme?

@foss-
Copy link
Author

foss- commented Oct 7, 2023

Mentioned where? Can you elaborate how to do that?

@prayag17
Copy link
Owner

prayag17 commented Oct 7, 2023

@foss-
Copy link
Author

foss- commented Oct 7, 2023

Oh that is maybe out of scope for me or will have to be postponed until the needed time is available as sadly I am not familiar with those mechanisms.

@prayag17
Copy link
Owner

prayag17 commented Oct 7, 2023

Ok. I will try to reproduce it myself

Edit: after doing some research, it turns out newer macos versions have some issues playing MP3 using web audio api.

@foss-
Copy link
Author

foss- commented Oct 7, 2023

Thanks for digging into this. How does Jellyfin WebUI resolve this or are they not using the web audio api?

@prayag17
Copy link
Owner

prayag17 commented Oct 7, 2023

Maybe they don't use MP3, I am not really sure. Since I don't have a Mac device I have no way of debugging this

@foss-
Copy link
Author

foss- commented Oct 8, 2023

Feishin just released 0.4.1 and they seem to have fixed identical issue as per the release notes:
Fixed playback not automatically continuing to the second song in the queue when starting playback from a fresh restart
https://github.com/jeffvli/feishin/releases/tag/v0.4.1
Fix is: jeffvli/feishin@5e10598

Tested and can confirm that when using Audio player > Web works and moves to the next tracks as expected.
However using Audio Player > MPV does not play any tracks at all in my test.

@prayag17
Copy link
Owner

prayag17 commented Oct 8, 2023

They seem to be using Electron which uses chromium which does not have this issue, the same reason why windows doesn't have this issue

@foss-
Copy link
Author

foss- commented Oct 8, 2023

Do you know if an open issue for the web audio API problem exists already and if yes, could you share the link?

@prayag17
Copy link
Owner

prayag17 commented Oct 8, 2023

I have switched from WebAudio Api to HtmlMedia element for audio playback which might fix this issue.

@foss-
Copy link
Author

foss- commented Dec 4, 2023

macOS 13.6.1
JellyPlayer 1.0.0 (20231203.103232)

Retested and first selected track still plays. Any other track which is selected won't play and player gets stuck.

@foss-
Copy link
Author

foss- commented Dec 8, 2023

This has improved with Version 1.0.0 (20231208.093929).

Track selection via track listing is possible and tracks are played after the initial track has been played.

Using Back | Forth arrow icons to go to previous | next track works.

What is not yet working is that quite frequently, however not always, track progress is not shown after the initial track has played and the progress indicator is stuck on the start of the track.

Sometime also the issue where tracks selected from album track listing are not played is also persisting.

@prayag17
Copy link
Owner

prayag17 commented Dec 8, 2023

Can you try the latest build (also ignore the update MSG, it is for testing)

@foss-
Copy link
Author

foss- commented Dec 9, 2023

Is the latest build https://github.com/prayag17/JellyPlayer/releases/tag/v1.0.0-dev%40abca227 ?
That shows as Version 1.0.0 (20231208.093929) which is the version I reported the current behavior for yesterday. Can you point me to the newer build please.

@prayag17
Copy link
Owner

prayag17 commented Dec 9, 2023

@foss-
Copy link
Author

foss- commented Dec 9, 2023

Same - while the second track does play (improvement over previous situation) the waveform indicator is not moving when the second track is playing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants