Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

float does not return to current column when called inside a column_box #1266

Open
mojavelinux opened this issue May 18, 2022 · 2 comments · May be fixed by #1267
Open

float does not return to current column when called inside a column_box #1266

mojavelinux opened this issue May 18, 2022 · 2 comments · May be fixed by #1267

Comments

@mojavelinux
Copy link
Contributor

When the float method is called inside a column box, it only restores the original page number and y, but not the current column. As a result, the ensuing content may be written to the wrong column.
@mojavelinux
Copy link
Contributor Author

I will submit a PR to resolve this issue.

@mojavelinux mojavelinux linked a pull request May 18, 2022 that will close this issue
Open
@mojavelinux
Copy link
Contributor Author

We might want to consider promoting the current_column instance variable to an accessor. It might also be nice to make the columns readable, but that's not needed for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

restore current column when float is called inside a column box mojavelinux/prawn
1 participant
@mojavelinux