Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 7309: Save operation sequence number #7310

Conversation

kuldeepk3
Copy link
Contributor

Change log description
Save operation sequence number for backup and restore.

Purpose of the change
Fixes #7309

What the code does
Saves operation metadata along with epoch for backup and restore.

How to verify it
(Optional: steps to verify that the changes are effective)

Signed-off-by: Kuldeep Kumar <Kuldeep.kumar3@dell.com>
Signed-off-by: Kuldeep Kumar <Kuldeep.kumar3@dell.com>
Signed-off-by: Kuldeep Kumar <Kuldeep.kumar3@dell.com>
@tkaitchuck tkaitchuck changed the title Save operation sequence number Issue 7309: Save operation sequence number Dec 11, 2023
@@ -62,10 +67,12 @@ protected void declareVersions() {

private void write00(EpochInfo object, RevisionDataOutput output) throws IOException {
output.writeCompactLong(object.epoch);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is adding a new feild, it should be in write01 and read01, and the revision should be updated to 1.

Copy link
Contributor

@sachin-j-joshi sachin-j-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuldeepk3 Is this change still needed?

@abhinb
Copy link
Contributor

abhinb commented Mar 8, 2024

this change already present on master. Closing this PR.

@abhinb abhinb closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save operation sequence number along with epoch info for backup and restore.
4 participants