-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 7166: Fixing durable log inspect command to give correct result #7171
base: master
Are you sure you want to change the base?
Issue 7166: Fixing durable log inspect command to give correct result #7171
Conversation
Signed-off-by: Kuldeep Kumar <Kuldeep.kumar3@dell.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7171 +/- ##
============================================
- Coverage 86.40% 86.37% -0.04%
- Complexity 16106 16174 +68
============================================
Files 1034 1034
Lines 59991 60057 +66
Branches 6107 6132 +25
============================================
+ Hits 51836 51875 +39
- Misses 4979 4992 +13
- Partials 3176 3190 +14
☔ View full report in Codecov by Sentry. |
Signed-off-by: Kuldeep Kumar <Kuldeep.kumar3@dell.com>
Signed-off-by: Kuldeep Kumar <Kuldeep.kumar3@dell.com>
Signed-off-by: Kuldeep Kumar <Kuldeep.kumar3@dell.com>
if (conditionTpe.equals(ATTRIBUTES)) { | ||
predicates.add(a -> a.getAttributes() == in); | ||
} | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If something other than "value" is used they will get "range". This is a serious problem if someone for example types "Value" or "value ".
Change log description
Updating DurableLogInspectCommand to return correct result when inspecting for Length, Offset, Attributes using either value or range.
Purpose of the change
Fixes #7166
What the code does
Adding code to evaluate condition when Length, Offset , Attributes are given.
How to verify it
Open admin cli and run durable log inspect command