Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to specify id for container #489

Merged
merged 1 commit into from Apr 25, 2022

Conversation

cyntler
Copy link
Contributor

@cyntler cyntler commented Apr 25, 2022

Hey @pradel! 馃憢
Please do a code review if you can ;)

Closes #483

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #489 (c32ef80) into master (dcc0c74) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
+ Coverage   95.26%   95.28%   +0.02%     
==========================================
  Files           6        6              
  Lines         190      191       +1     
  Branches       69       69              
==========================================
+ Hits          181      182       +1     
  Misses          9        9              
Impacted Files Coverage 螖
react-responsive-modal/src/index.tsx 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update dcc0c74...c32ef80. Read the comment docs.

@pradel pradel merged commit 3e09b5c into pradel:master Apr 25, 2022
@pradel
Copy link
Owner

pradel commented Apr 25, 2022

Thanks!

@cyntler cyntler deleted the add-container-id branch April 25, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to specify an id for modal-container
2 participants