Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional reserveScrollBarGap #484

Merged
merged 3 commits into from Dec 14, 2021

Conversation

huksley
Copy link
Contributor

@huksley huksley commented Dec 13, 2021

improved #475 for more information see original PR
Optional reserveScrollBarGap={true}

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #484 (ca6b224) into master (61c3493) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head ca6b224 differs from pull request most recent head a19e9d0. Consider uploading reports for the commit a19e9d0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
+ Coverage   95.23%   95.26%   +0.02%     
==========================================
  Files           6        6              
  Lines         189      190       +1     
  Branches       70       69       -1     
==========================================
+ Hits          180      181       +1     
  Misses          9        9              
Impacted Files Coverage Δ
react-responsive-modal/src/index.tsx 100.00% <100.00%> (ø)
react-responsive-modal/src/useScrollLock.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61c3493...a19e9d0. Read the comment docs.

@pradel
Copy link
Owner

pradel commented Dec 14, 2021

@huksley thanks for the pr! Could you change the size so the CI pass please?

@huksley
Copy link
Contributor Author

huksley commented Dec 14, 2021

@pradel Done

react-responsive-modal/package.json Outdated Show resolved Hide resolved
@pradel pradel merged commit 69249f8 into pradel:master Dec 14, 2021
@huksley huksley deleted the reserveScrollBarGap branch December 14, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants